Mirrors/flux2
1
0
Fork 0
mirror of synced 2026-02-06 19:05:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: #5654 by check if both --chart and --chart-ref are set

Browse Source 
Signed-off-by: Jesper Axelsen <jesperbaxelsen@gmail.com>
This commit is contained in:
Jesper Axelsen
2025-12-10 21:46:50 +01:00
parent 9b76ba19a8
commit 3fb05a604f
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/flux/create_helmrelease.go
View File

@@ -182,6 +182,10 @@ func createHelmReleaseCmdRun(cmd *cobra.Command, args []string) error {
return fmt.Errorf("chart or chart-ref is required") return fmt.Errorf("chart or chart-ref is required")
} }
if helmReleaseArgs.chart != "" && helmReleaseArgs.chartRef != "" {
return fmt.Errorf("cannot use --chart in combination with --chart-ref")
}
sourceLabels, err := parseLabels() sourceLabels, err := parseLabels()
if err != nil { if err != nil {
return err return err

5
cmd/flux/create_helmrelease_test.go
View File

@@ -42,6 +42,11 @@ func TestCreateHelmRelease(t *testing.T) {
args: "create helmrelease podinfo --export", args: "create helmrelease podinfo --export",
assert: assertError("chart or chart-ref is required"), assert: assertError("chart or chart-ref is required"),
}, },
{
name: "chart and chartRef used in combination",
args: "create helmrelease podinfo --chart podinfo --chart-ref foobar/podinfo --export",
assert: assertError("cannot use --chart in combination with --chart-ref"),
},
{ {
name: "unknown source kind", name: "unknown source kind",
args: "create helmrelease podinfo --source foobar/podinfo --chart podinfo --export", args: "create helmrelease podinfo --source foobar/podinfo --chart podinfo --export",