fix(cli): handle error when writing password prompt and correct spelling (i) Add error handling for fmt.Fprint when writing password prompt to stdout (ii) Fixed : initalization to initialization in the commented region

Signed-off-by: Akshat Sinha <akshatsinhasramhardy@gmail.com>
pull/5589/head
Akshat Sinha 16 hours ago
parent 9f18062d43
commit 5b37a6b04b

@ -180,7 +180,7 @@ func main() {
// This is required because controller-runtime expects its consumers to // This is required because controller-runtime expects its consumers to
// set a logger through log.SetLogger within 30 seconds of the program's // set a logger through log.SetLogger within 30 seconds of the program's
// initalization. If not set, the entire debug stack is printed as an // initialization. If not set, the entire debug stack is printed as an
// error, see: https://github.com/kubernetes-sigs/controller-runtime/blob/ed8be90/pkg/log/log.go#L59 // error, see: https://github.com/kubernetes-sigs/controller-runtime/blob/ed8be90/pkg/log/log.go#L59
// Since we have our own logging and don't care about controller-runtime's // Since we have our own logging and don't care about controller-runtime's
// logger, we configure it's logger to do nothing. // logger, we configure it's logger to do nothing.
@ -225,7 +225,9 @@ func configureDefaultNamespace() {
func readPasswordFromStdin(prompt string) (string, error) { func readPasswordFromStdin(prompt string) (string, error) {
var out string var out string
var err error var err error
fmt.Fprint(os.Stdout, prompt) if _, err := fmt.Fprint(os.Stdout, prompt); err != nil {
return "", fmt.Errorf("failed to write prompt: %w", err)
}
stdinFD := int(os.Stdin.Fd()) stdinFD := int(os.Stdin.Fd())
if term.IsTerminal(stdinFD) { if term.IsTerminal(stdinFD) {
var inBytes []byte var inBytes []byte

Loading…
Cancel
Save