From 7515080c6370fc124df40549742f629aa9ef5b27 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Fri, 16 Oct 2020 21:54:24 +0200 Subject: [PATCH] Remove documentation version hotfix And re-use the same logic to properly compare current and next release versions in update workflow. --- .github/workflows/docs.yaml | 14 +++++--------- .github/workflows/update.yml | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml index a0a64098..8f8c8c5d 100644 --- a/.github/workflows/docs.yaml +++ b/.github/workflows/docs.yaml @@ -15,18 +15,14 @@ jobs: - name: Copy assets env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SOURCE_VER: ${{ 'v0.1.1' }} - KUSTOMIZE_VER: ${{ 'v0.1.1' }} - HELM_VER: ${{ 'v0.1.2' }} - NOTIFICATION_VER: ${{ 'v0.1.1' }} run: | controller_version() { - sed -n "s/\(.*$1\/.*?ref=\)//p;n" "manifests/bases/$1/kustomization.yaml" + sed -n "s/.*$1\/archive\/\(.*\).zip.*/\1/p;n" manifests/bases/$1/kustomization.yaml } { # source-controller CRDs - # SOURCE_VER=$(controller_version source-controller) + SOURCE_VER=$(controller_version source-controller) curl -# -Lf "https://raw.githubusercontent.com/fluxcd/source-controller/$SOURCE_VER/docs/api/source.md" > docs/components/source/api.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/source-controller/$SOURCE_VER/docs/spec/v1beta1/gitrepositories.md" > docs/components/source/gitrepositories.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/source-controller/$SOURCE_VER/docs/spec/v1beta1/helmrepositories.md" > docs/components/source/helmrepositories.md @@ -36,21 +32,21 @@ jobs: { # kustomize-controller CRDs - # KUSTOMIZE_VER=$(controller_version kustomize-controller) + KUSTOMIZE_VER=$(controller_version kustomize-controller) curl -# -Lf "https://raw.githubusercontent.com/fluxcd/kustomize-controller/$KUSTOMIZE_VER/docs/api/kustomize.md" > docs/components/kustomize/api.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/kustomize-controller/$KUSTOMIZE_VER/docs/spec/v1beta1/kustomization.md" > docs/components/kustomize/kustomization.md } { # helm-controller CRDs - # HELM_VER=$(controller_version helm-controller) + HELM_VER=$(controller_version helm-controller) curl -# -Lf "https://raw.githubusercontent.com/fluxcd/helm-controller/$HELM_VER/docs/api/helmrelease.md" > docs/components/helm/api.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/helm-controller/$HELM_VER/docs/spec/v2beta1/helmreleases.md" > docs/components/helm/helmreleases.md } { # notification-controller CRDs - # NOTIFICATION_VER=$(controller_version notification-controller) + NOTIFICATION_VER=$(controller_version notification-controller) curl -# -Lf "https://raw.githubusercontent.com/fluxcd/notification-controller/$NOTIFICATION_VER/docs/api/notification.md" > docs/components/notification/api.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/notification-controller/$NOTIFICATION_VER/docs/spec/v1beta1/event.md" > docs/components/notification/event.md curl -# -Lf "https://raw.githubusercontent.com/fluxcd/notification-controller/$NOTIFICATION_VER/docs/spec/v1beta1/alert.md" > docs/components/notification/alert.md diff --git a/.github/workflows/update.yml b/.github/workflows/update.yml index 5ca972e8..42bd191b 100644 --- a/.github/workflows/update.yml +++ b/.github/workflows/update.yml @@ -19,7 +19,7 @@ jobs: bump_version() { local RELEASE_VERSION=$(curl -s https://api.github.com/repos/fluxcd/$1/releases | jq -r 'sort_by(.published_at) | .[-1] | .tag_name') - local CURRENT_VERSION=$(sed -n "s/\(.*$1\/.*?ref=\)//p;n" "manifests/bases/$1/kustomization.yaml") + local CURRENT_VERSION=$(sed -n "s/.*$1\/archive\/\(.*\).zip.*/\1/p;n" manifests/bases/$1/kustomization.yaml) if [[ "${RELEASE_VERSION}" != "${CURRENT_VERSION}" ]]; then # bump kustomize