diff --git a/cmd/flux/migrate.go b/cmd/flux/migrate.go index 7beba3c7..2e39527c 100644 --- a/cmd/flux/migrate.go +++ b/cmd/flux/migrate.go @@ -623,7 +623,8 @@ func (f *FileSystemMigrator) detectFileUpgrades(file string) ([]APIUpgrade, erro if idx == -1 { continue } - kind := strings.TrimSpace(kindLine[idx+len(kindPrefix):]) + kindValuePrefix := strings.TrimSpace(kindLine[idx+len(kindPrefix):]) + kind := strings.Split(kindValuePrefix, " ")[0] // Build GroupKind. gk := schema.GroupKind{ diff --git a/cmd/flux/migrate_test.go b/cmd/flux/migrate_test.go index 48d8fbf5..0820fb82 100644 --- a/cmd/flux/migrate_test.go +++ b/cmd/flux/migrate_test.go @@ -153,7 +153,7 @@ func TestFileSystemMigrator(t *testing.T) { for _, wf := range tt.writtenFiles { b, err := os.ReadFile(wf.goldenFile) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(fileSystem.writtenFiles[wf.file]).To(Equal(b), + g.Expect(string(fileSystem.writtenFiles[wf.file])).To(Equal(string(b)), "file %s does not match golden file %s", wf.file, wf.goldenFile) } }) diff --git a/cmd/flux/testdata/migrate/file-system/dir.golden/some-file.yaml b/cmd/flux/testdata/migrate/file-system/dir.golden/some-file.yaml index 8b8ed51b..c00aba16 100644 --- a/cmd/flux/testdata/migrate/file-system/dir.golden/some-file.yaml +++ b/cmd/flux/testdata/migrate/file-system/dir.golden/some-file.yaml @@ -12,7 +12,7 @@ spec: wait: true dependsOn: - apiVersion: image.toolkit.fluxcd.io/v1 # update this from v1beta1 - kind: ImageRepository + kind: ImageRepository # there can be comments here too --- diff --git a/cmd/flux/testdata/migrate/file-system/dir/some-file.yaml b/cmd/flux/testdata/migrate/file-system/dir/some-file.yaml index a8b2be01..a3016732 100644 --- a/cmd/flux/testdata/migrate/file-system/dir/some-file.yaml +++ b/cmd/flux/testdata/migrate/file-system/dir/some-file.yaml @@ -12,7 +12,7 @@ spec: wait: true dependsOn: - apiVersion: image.toolkit.fluxcd.io/v1beta1 # update this from v1beta1 - kind: ImageRepository + kind: ImageRepository # there can be comments here too ---