Merge pull request #5566 from ramasai1/refactor-variable-sub

refactor: convert `Kustomization` resource into unstructured map only once during variable substitution
pull/5568/head
Stefan Prodan 1 week ago committed by GitHub
commit 8e99cf7c93
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -520,13 +520,16 @@ func (b *Builder) do(ctx context.Context, kustomization kustomizev1.Kustomizatio
return nil, fmt.Errorf("kustomize build failed: %w", err) return nil, fmt.Errorf("kustomize build failed: %w", err)
} }
for _, res := range m.Resources() { if kustomization.Spec.PostBuild == nil {
// run variable substitutions return m, nil
if kustomization.Spec.PostBuild != nil { }
data, err := runtime.DefaultUnstructuredConverter.ToUnstructured(&kustomization) data, err := runtime.DefaultUnstructuredConverter.ToUnstructured(&kustomization)
if err != nil { if err != nil {
return nil, err return nil, err
} }
for _, res := range m.Resources() {
// run variable substitutions
outRes, err := kustomize.SubstituteVariables(ctx, outRes, err := kustomize.SubstituteVariables(ctx,
b.client, b.client,
unstructured.Unstructured{Object: data}, unstructured.Unstructured{Object: data},
@ -545,7 +548,6 @@ func (b *Builder) do(ctx context.Context, kustomization kustomizev1.Kustomizatio
} }
} }
} }
}
return m, nil return m, nil
} }

Loading…
Cancel
Save