1
0
mirror of synced 2026-03-14 15:36:56 +00:00

Merge pull request #3990 from fluxcd/rfc-insecure-http

RFC-0004: add section about proxy
This commit is contained in:
Sanskar Jaiswal
2023-06-26 19:27:50 +05:30
committed by GitHub

View File

@@ -4,7 +4,7 @@
**Creation Date:** 2022-09-08 **Creation Date:** 2022-09-08
**Last update:** 2022-10-21 **Last update:** 2023-07-26
## Summary ## Summary
@@ -111,6 +111,17 @@ for the required commands, which will be used for specifying the value of `.spec
> Note: This flag should not be confused with `--insecure-skip-tls-verify` which is meant to skip TLS verification > Note: This flag should not be confused with `--insecure-skip-tls-verify` which is meant to skip TLS verification
> when using an HTTPS connection. > when using an HTTPS connection.
### Proxy
The flag shall also apply to all possible proxy configurations. If the flag `--insecure-allow-http` is set to
`false`, then specifying the `HTTP_PROXY` environment variable to the controller will lead to the controller
exiting with a failure on startup. This also applies for when the `HTTPS_PROXY` enviornment variable's value is
a URL that has `http` as its scheme.
Similarly, if a proxy is specified using the object's API, such as through `.spec.secretRef` in `Provider` in the
`notification.toolkit.fluxcd.io` API group and the proxy URL has `http` as its scheme, the reconciler will fail and
return an error, which can be viewed in the controller logs and the object's events.
### Precedence & Validity ### Precedence & Validity
Objects with `.spec.insecure` as `true` will only be allowed if HTTP connections are allowed at the controller level. Objects with `.spec.insecure` as `true` will only be allowed if HTTP connections are allowed at the controller level.