Mirrors/flux2
1
0
Fork 0
mirror of synced 2026-03-16 16:16:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4177 from fluxcd/min-rsa-size

Browse Source 
Set min value for the `--ssh-rsa-bits` flag
This commit is contained in:
Stefan Prodan
2023-08-22 11:59:35 +03:00
committed by GitHub
parent a9e09b856f 2c76c70205
commit eac82585ad
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/flags/rsa_key_bits.go
View File

@@ -39,6 +39,9 @@ func (b *RSAKeyBits) Set(str string) error {
if err != nil { if err != nil {
return err return err
} }
if bits < 1024 {
return fmt.Errorf("RSA key bit size must be at least 1024")
}
if bits == 0 || bits%8 != 0 { if bits == 0 || bits%8 != 0 {
return fmt.Errorf("RSA key bit size must be a multiples of 8") return fmt.Errorf("RSA key bit size must be a multiples of 8")
} }
@@ -51,5 +54,5 @@ func (b *RSAKeyBits) Type() string {
} }
func (b *RSAKeyBits) Description() string { func (b *RSAKeyBits) Description() string {
return "SSH RSA public key bit size (multiplies of 8)" return "SSH RSA public key bit size (multiplies of 8, min 1024)"
} }

4
internal/flags/rsa_key_bits_test.go
View File

@@ -32,8 +32,8 @@ func TestRSAKeyBits_Set(t *testing.T) {
}{ }{
{"supported", "4096", "4096", false}, {"supported", "4096", "4096", false},
{"empty (default)", "", "2048", false}, {"empty (default)", "", "2048", false},
{"unsupported", "0", "0", true}, {"unsupported", "512", "0", true},
{"unsupported", "123", "0", true}, {"unsupported", "1025", "0", true},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {