From f234f2f26fc3599bf7401c3ef3dc888903577076 Mon Sep 17 00:00:00 2001
From: Matheus Pimenta <matheuscscp@gmail.com>
Date: Thu, 25 Jun 2026 08:27:45 +0100
Subject: [PATCH] Simplify status filter in get command

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
---
 cmd/flux/get.go | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/cmd/flux/get.go b/cmd/flux/get.go
index 971d7828..09fb7da9 100644
--- a/cmd/flux/get.go
+++ b/cmd/flux/get.go
@@ -228,16 +228,20 @@ func namespaceNameOrAny(allNamespaces bool, namespaceName string) string {
 }
 
 func getRowsToPrint(getAll bool, list summarisable) ([][]string, error) {
-	noFilter := true
+	filter := func(i int) bool { return true }
 	var conditionType, conditionStatus string
-	var negate bool
 	if getArgs.statusSelector != "" {
 		// Support both type=status (match) and type!=status (negated match).
 		// "!=" must be checked first since it also contains "=".
 		separator := "="
+		filter = func(i int) bool {
+			return list.statusSelectorMatches(i, conditionType, conditionStatus)
+		}
 		if strings.Contains(getArgs.statusSelector, "!=") {
 			separator = "!="
-			negate = true
+			filter = func(i int) bool {
+				return !list.statusSelectorMatches(i, conditionType, conditionStatus)
+			}
 		}
 		parts := strings.SplitN(getArgs.statusSelector, separator, 2)
 		if len(parts) != 2 {
@@ -245,21 +249,13 @@ func getRowsToPrint(getAll bool, list summarisable) ([][]string, error) {
 		}
 		conditionType = parts[0]
 		conditionStatus = parts[1]
-		noFilter = false
 	}
 	var rows [][]string
 	for i := 0; i < list.len(); i++ {
-		if !noFilter {
-			matches := list.statusSelectorMatches(i, conditionType, conditionStatus)
-			if negate {
-				matches = !matches
-			}
-			if !matches {
-				continue
-			}
+		if filter(i) {
+			row := list.summariseItem(i, getArgs.allNamespaces, getAll)
+			rows = append(rows, row)
 		}
-		row := list.summariseItem(i, getArgs.allNamespaces, getAll)
-		rows = append(rows, row)
 	}
 	return rows, nil
 }