flux2

Commit Graph

Author	SHA1	Message	Date
Michael Bridgen	22a5ac7f0f	Standardise the names of types Most commands use either a kind, or a more readable spelling of a kind, in their output. To make this easier, this centralises the definition of those names in one place, and lets the command implementations choose whichever they need. Signed-off-by: Michael Bridgen <michael@weave.works>	4 years ago
Michael Bridgen	2bb09697ce	Centralise adapter types Since the generic commands tend to share a few of the methods they need -- at least AsClientObject -- it's worth having just one wrapper struct for each API type, and adding methods to it where necessary. For the automation types, I put these in auto.go. While doing this I also did some tidying: - I changed the name of the wrappers to `<type>Adapter`, and the generic adapter to `universalAdapter` (it's only needed for delete, so far). - I de-exported and renamed some interface methods e.g., `exportItem`. They aren't needed outside the package. Signed-off-by: Michael Bridgen <michael@weave.works>	4 years ago
Michael Bridgen	52145c045d	Add delete image-policy and refactor This adds a command for deleting ImagePolicy objects. Since the control flow for the command needs only a runtime.Object (and a name for the type), it can be factored out. I have made the argument (field in the deleteCommand struct) an interface `objectContainer`, through which the command code gets a `runtime.Object` to deserialise into (and delete). It could be simply a `runtime.Object` here; however things like `getCommand` require other methods, so it's convenient to have an interface for it. Signed-off-by: Michael Bridgen <michael@weave.works>	4 years ago

Author

SHA1

Message

Date

Michael Bridgen

22a5ac7f0f

Standardise the names of types

Most commands use either a kind, or a more readable spelling of a
kind, in their output. To make this easier, this centralises the
definition of those names in one place, and lets the command
implementations choose whichever they need.

Signed-off-by: Michael Bridgen <michael@weave.works>

Michael Bridgen

2bb09697ce

Centralise adapter types

Since the generic commands tend to share a few of the methods they
need -- at least AsClientObject -- it's worth having just one wrapper
struct for each API type, and adding methods to it where necessary.

For the automation types, I put these in auto.go.

While doing this I also did some tidying:

 - I changed the name of the wrappers to `<type>Adapter`, and the
   generic adapter to `universalAdapter` (it's only needed for delete,
   so far).

 - I de-exported and renamed some interface methods e.g.,
   `exportItem`. They aren't needed outside the package.

Signed-off-by: Michael Bridgen <michael@weave.works>

Michael Bridgen

52145c045d

Add delete image-policy and refactor

This adds a command for deleting ImagePolicy objects. Since the
control flow for the command needs only a runtime.Object (and a name
for the type), it can be factored out.

I have made the argument (field in the deleteCommand struct) an
interface `objectContainer`, through which the command code gets a
`runtime.Object` to deserialise into (and delete). It could be simply
a `runtime.Object` here; however things like `getCommand` require
other methods, so it's convenient to have an interface for it.

Signed-off-by: Michael Bridgen <michael@weave.works>

3 Commits (3b9b2cbe9fc5ecda5be8f02c8849609b6509601d)