flux2

Commit Graph

Author	SHA1	Message	Date
Andrew Jenkins	437a7a2852	Fix failure in TestTrace/* when timezone isn't UTC The TestTrace/Deployment and TestTrace/HelmRelease test cases fail in environments where the timezone isn't UTC, because they compare a local time string to the golden file, which has time in UTC. Here is an example: ``` --- FAIL: TestTrace (0.12s) --- FAIL: TestTrace/Deployment (0.08s) main_test.go:337: Mismatch from golden file 'testdata/trace/deployment.golden': Mismatch from expected value (-want +got): strings.Join({ ... // 88 identical bytes " Flux\n---\nHelmRelease: podinfo\nNamespace: podinfo-8\nRevi", "sion: 6.0.0\nStatus: Last reconciled at 2021-07-16 ", - "15:42:20 +0000 UTC", + "09:42:20 -0600 MDT", "\nMessage: Release reconciliation succeeded\n---\nHelmChart:", " podinfo-podinfo\nNamespace: flux-system-9\nChart: ", " podinfo\nVersion: 6.0.0\nRevision: 6.0.0\nStatus: ", " Last reconciled at 2021-07-16 ", - "15:32:09 +0000 UTC", + "09:32:09 -0600 MDT", "\nMessage: Fetched revision: 6.0.0\n---\nHelmRepository: pod", "info\nNamespace: flux-system-9\nURL: https://stefa", "nprodan.github.io/podinfo\nRevision: 8411f23d07d3701f0e96e7", "d9e503b7936d7e1d56\nStatus: Last reconciled at 2021-07-", - "1", "1", - " 00:25:46 +0000 UTC", + "0 18:25:46 -0600 MDT", "\nMessage: Fetched revision: 8411f23d07d3701f0e96e7d9e503b", "7936d7e1d56\n", }, "") ``` This commit fixes the issue by converting the golden test times to local time before comparing. The utility function toLocalTime() is added to trace_test.go, and then it is used to provide localized times as template parameters to the golden files. Signed-off-by: Andrew Jenkins <andrew@aspenmesh.io>	3 years ago
Allen Porter	d45501a129	Use shared envTest for unit tests Speed up unit tests by using a shared envTest. This requires each test to use its own namespace to avoid clobbering objects for other tests. Tests previously took around 8 seconds each, and now the initial test takes 2 seconds with follow up tests taking less than a second each. Also update existing tests that use a fixed namespace to use a generated namespace. Share gold file template function with yaml files. Remove the testClusterMode, and instead rely on MainTest to do the appropriate test setup and rootArgs flag setup. Move the rootArg flag setup out of NewTestEnvKubeManager to avoid side effects. A follow up change can be to push the individual setups from NewTestEnvKubeManager() into their respective TestMain since the harness share little code. Signed-off-by: Allen Porter <allen@thebends.org>	3 years ago
Allen Porter	11708d4189	Rename trace test golden files Rename trace test golden files to match the convention used by other tests Signed-off-by: Allen Porter <allen@thebends.org>	3 years ago
Allen Porter	e8d6d5fe5c	Remove fakeclient and use testenv for flux cmd tests Remove use of the fake client, and replace with a real client connected to the testEnv. This required fixes to the yaml files as the testEnv has stricter verifcation of objects. This also meant it was not possible to test a GitRepository with a missing artifact since that is not a valid state. The tests are slower than before, taking around 7-10 seconds each because the testEnv is setup and destroyed for every test. These will be sped up in a follow up PR. Signed-off-by: Allen Porter <allen@thebends.org>	3 years ago
Stefan Prodan	dd0f17d7a5	Refactor test helpers - move test helpers to main - add support for inline golden values - add test for `flux --version` Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>	3 years ago
Allen Porter	351d287d88	Add tests for flux trace command Add tests for flux trace command that fake out the kubernetes client, load objects from a yaml file and create them in the client, and assert on the output of the trace command to an expected golden file. This is a follow up from the suggestions in PR https://github.com/fluxcd/flux2/pull/1626 which suggested that additional testing would be helpful. This test approach is modeled after the helm command tests. This required some changes to the kubernetes client setup to make it possible to use a fake. If we agree this pattern makes sense, it can be applied to other commands. Signed-off-by: Allen Porter <allen@thebends.org>	3 years ago

6 Commits (4c576bf59920a34663128a9f7aa3f2dc0e9bd8eb)