From 85c86311838d2069817d1cc0bba68547883c6550 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrien=20Verg=C3=A9?= Date: Tue, 29 Sep 2020 08:25:43 +0200 Subject: [PATCH] tests: Stop using deprecated 'python setup.py test' Using `python setup.py test` is now deprecated [1], users are encouraged to be explicit about the test command. Running yamllint tests using the Python standard library (`unittest`) can be done using: python -m unittest discover Why not nose, tox or pytest? Because they would add a dependency, make tests running more complicated and verbose for new users, and their benefit is not worth for this simple project (only 2 runtime dependencies: PyYAML and pathspec). Resolves https://github.com/adrienverge/yamllint/issues/328. [1]: https://github.com/pypa/setuptools/pull/1878 --- .travis.yml | 2 +- CONTRIBUTING.rst | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2f6b3ba..c7c311c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,7 +20,7 @@ script: - if [[ $TRAVIS_PYTHON_VERSION != nightly ]]; then flake8 .; fi - if [[ $TRAVIS_PYTHON_VERSION != 2* ]]; then doc8 $(git ls-files '*.rst'); fi - yamllint --strict $(git ls-files '*.yaml' '*.yml') - - coverage run --source=yamllint setup.py test + - coverage run --source=yamllint -m unittest discover - if [[ $TRAVIS_PYTHON_VERSION != 2* ]]; then python setup.py build_sphinx; fi diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index af32122..f57ec5e 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -13,7 +13,9 @@ Pull Request Process .. code:: bash - python setup.py test + pip install --user . + python -m unittest discover # all tests... + python -m unittest tests/rules/test_commas.py # or just some tests (faster) 3. If you add code that should be tested, add tests.