yamllint version 1.13.0

`-f standard` shows non-colored output,
`-f colored` shows colored output,
`-f auto` is the new default, it chooses `standard` or `colored`
depending on terminal capabilities.

.gitignore

@@ -3,3 +3,4 @@ __pycache__
 /docs/_build
 /dist
 /yamllint.egg-info
+/build

CHANGELOG.rst

@@ -1,6 +1,19 @@
 Changelog
 =========
 
+1.13.0 (2018-11-14)
+-------------------
+
+- Use `isinstance(x, y)` instead of `type(x) == y`
+- Add a new `-f colored` option
+- Update documentation about colored output when run from CLI
+
+1.12.1 (2018-10-17)
+-------------------
+
+- Fix the `quoted-strings` rule, broken implementation
+- Fix missing documentation for the `quoted-strings` rule
+
 1.12.0 (2018-10-04)
 -------------------
 

docs/configuration.rst

@@ -102,8 +102,8 @@ Errors and warnings
 -------------------
 
 Problems detected by yamllint can be raised either as errors or as warnings.
-The CLI will output them (with different colors when using the ``standard``
+The CLI will output them (with different colors when using the ``colored``
-output format).
+output format, or ``auto`` when run from a terminal).
 
 By default the script will exit with a return code ``1`` *only when* there is one or
 more error(s).

docs/quickstart.rst

@@ -68,6 +68,10 @@ The output will look like (colors are not displayed here):
    10:1      error    too many blank lines (4 > 2)  (empty-lines)
    11:4      error    too many spaces inside braces  (braces)
 
+By default, the output of yamllint is colored when run from a terminal, and pure
+text in other cases. Add the ``-f standard`` arguments to force non-colored output.
+Use the ``-f colored`` arguments to force colored output.
+
 Add the ``-f parsable`` arguments if you need an output format parsable by a
 machine (for instance for :doc:`syntax highlighting in text editors
 <text_editors>`). The output will then look like:

docs/rules.rst

@@ -104,6 +104,11 @@ octal-values
 
 .. automodule:: yamllint.rules.octal_values
 
+quoted-strings
+--------------
+
+.. automodule:: yamllint.rules.quoted_strings
+
 trailing-spaces
 ---------------
 

tests/rules/test_quoted_strings.py

@@ -34,19 +34,19 @@ class QuotedTestCase(RuleTestCase):
     def test_quote_type_any(self):
         conf = 'quoted-strings: {quote-type: any}\n'
         self.check('---\n'
-                   'string1: "foo"\n'
+                   'boolean1: true\n'
-                   'number1: 123\n'                          # fails
+                   'number1: 123\n'
-                   'string2: foo\n'                          # fails
+                   'string1: foo\n'                          # fails
+                   'string2: "foo"\n'
                    'string3: \'bar\'\n'
-                   'string4: !!str genericstring\n'          # fails
+                   'string4: !!str genericstring\n'
-                   'string5: !!str 456\n'                    # fails
+                   'string5: !!str 456\n'
                    'string6: !!str "quotedgenericstring"\n'
                    'binary: !!binary binstring\n'
                    'integer: !!int intstring\n'
-                   'boolean1: !!bool boolstring\n'
+                   'boolean2: !!bool boolstring\n'
-                   'boolean2: !!bool "quotedboolstring"\n',
+                   'boolean3: !!bool "quotedboolstring"\n',
-                   conf, problem1=(3, 10), problem2=(4, 10),
+                   conf, problem=(4, 10))
-                   problem3=(6, 16), problem4=(7, 16))
         self.check('---\n'
                    'multiline string 1: |\n'
                    '  line 1\n'
@@ -65,19 +65,19 @@ class QuotedTestCase(RuleTestCase):
     def test_quote_type_single(self):
         conf = 'quoted-strings: {quote-type: single}\n'
         self.check('---\n'
-                   'string1: "foo"\n'                        # fails
+                   'boolean1: true\n'
-                   'number1: 123\n'                          # fails
+                   'number1: 123\n'
-                   'string2: foo\n'                          # fails
+                   'string1: foo\n'                          # fails
+                   'string2: "foo"\n'                        # fails
                    'string3: \'bar\'\n'
-                   'string4: !!str genericstring\n'          # fails
+                   'string4: !!str genericstring\n'
-                   'string5: !!str 456\n'                    # fails
+                   'string5: !!str 456\n'
-                   'string6: !!str "quotedgenericstring"\n'  # fails
+                   'string6: !!str "quotedgenericstring"\n'
                    'binary: !!binary binstring\n'
                    'integer: !!int intstring\n'
-                   'boolean1: !!bool boolstring\n'
+                   'boolean2: !!bool boolstring\n'
-                   'boolean2: !!bool "quotedboolstring"\n',
+                   'boolean3: !!bool "quotedboolstring"\n',
-                   conf, problem1=(2, 10), problem2=(3, 10), problem3=(4, 10),
+                   conf, problem1=(4, 10), problem2=(5, 10))
-                   problem4=(6, 16), problem5=(7, 16), problem6=(8, 16))
         self.check('---\n'
                    'multiline string 1: |\n'
                    '  line 1\n'
@@ -96,19 +96,19 @@ class QuotedTestCase(RuleTestCase):
     def test_quote_type_double(self):
         conf = 'quoted-strings: {quote-type: double}\n'
         self.check('---\n'
-                   'string1: "foo"\n'
+                   'boolean1: true\n'
-                   'number1: 123\n'                          # fails
+                   'number1: 123\n'
-                   'string2: foo\n'                          # fails
+                   'string1: foo\n'                          # fails
+                   'string2: "foo"\n'
                    'string3: \'bar\'\n'                      # fails
-                   'string4: !!str genericstring\n'          # fails
+                   'string4: !!str genericstring\n'
-                   'string5: !!str 456\n'                    # fails
+                   'string5: !!str 456\n'
                    'string6: !!str "quotedgenericstring"\n'
                    'binary: !!binary binstring\n'
                    'integer: !!int intstring\n'
-                   'boolean1: !!bool boolstring\n'
+                   'boolean2: !!bool boolstring\n'
-                   'boolean2: !!bool "quotedboolstring"\n',
+                   'boolean3: !!bool "quotedboolstring"\n',
-                   conf, problem1=(3, 10), problem2=(4, 10), problem3=(5, 10),
+                   conf, problem1=(4, 10), problem2=(6, 10))
-                   problem4=(6, 16), problem5=(7, 16))
         self.check('---\n'
                    'multiline string 1: |\n'
                    '  line 1\n'

tests/test_cli.py

@@ -351,7 +351,7 @@ class CommandLineTestCase(unittest.TestCase):
             '\n' % file))
         self.assertEqual(err, '')
 
-    def test_run_colored_output(self):
+    def test_run_default_format_output_in_tty(self):
         file = os.path.join(self.wd, 'a.yaml')
 
         # Create a pseudo-TTY and redirect stdout to it
@@ -383,3 +383,59 @@ class CommandLineTestCase(unittest.TestCase):
             'no new line character at the end of file  '
             '\033[2m(new-line-at-end-of-file)\033[0m\n'
             '\n' % file))
+
+    def test_run_default_format_output_without_tty(self):
+        file = os.path.join(self.wd, 'a.yaml')
+
+        sys.stdout, sys.stderr = StringIO(), StringIO()
+        with self.assertRaises(SystemExit) as ctx:
+            cli.run((file, ))
+
+        self.assertEqual(ctx.exception.code, 1)
+
+        out, err = sys.stdout.getvalue(), sys.stderr.getvalue()
+        self.assertEqual(out, (
+            '%s\n'
+            '  2:4       error    trailing spaces  (trailing-spaces)\n'
+            '  3:4       error    no new line character at the end of file  '
+            '(new-line-at-end-of-file)\n'
+            '\n' % file))
+        self.assertEqual(err, '')
+
+    def test_run_auto_output_without_tty_output(self):
+        file = os.path.join(self.wd, 'a.yaml')
+
+        sys.stdout, sys.stderr = StringIO(), StringIO()
+        with self.assertRaises(SystemExit) as ctx:
+            cli.run((file, '--format', 'auto'))
+
+        self.assertEqual(ctx.exception.code, 1)
+
+        out, err = sys.stdout.getvalue(), sys.stderr.getvalue()
+        self.assertEqual(out, (
+            '%s\n'
+            '  2:4       error    trailing spaces  (trailing-spaces)\n'
+            '  3:4       error    no new line character at the end of file  '
+            '(new-line-at-end-of-file)\n'
+            '\n' % file))
+        self.assertEqual(err, '')
+
+    def test_run_format_colored(self):
+        file = os.path.join(self.wd, 'a.yaml')
+
+        sys.stdout, sys.stderr = StringIO(), StringIO()
+        with self.assertRaises(SystemExit) as ctx:
+            cli.run((file, '--format', 'colored'))
+
+        self.assertEqual(ctx.exception.code, 1)
+
+        out, err = sys.stdout.getvalue(), sys.stderr.getvalue()
+        self.assertEqual(out, (
+            '\033[4m%s\033[0m\n'
+            '  \033[2m2:4\033[0m       \033[31merror\033[0m    '
+            'trailing spaces  \033[2m(trailing-spaces)\033[0m\n'
+            '  \033[2m3:4\033[0m       \033[31merror\033[0m    '
+            'no new line character at the end of file  '
+            '\033[2m(new-line-at-end-of-file)\033[0m\n'
+            '\n' % file))
+        self.assertEqual(err, '')

yamllint/__init__.py

@@ -22,7 +22,7 @@ indentation, etc."""
 
 
 APP_NAME = 'yamllint'
-APP_VERSION = '1.12.0'
+APP_VERSION = '1.13.0'
 APP_DESCRIPTION = __doc__
 
 __author__ = u'Adrien Vergé'

yamllint/cli.py

@@ -96,8 +96,8 @@ def run(argv=None):
                               action='store',
                               help='custom configuration (as YAML source)')
     parser.add_argument('-f', '--format',
-                        choices=('parsable', 'standard'), default='standard',
+                        choices=('parsable', 'standard', 'colored', 'auto'),
-                        help='format for parsing output')
+                        default='auto', help='format for parsing output')
     parser.add_argument('-s', '--strict',
                         action='store_true',
                         help='return non-zero exit code on warnings '
@@ -143,7 +143,8 @@ def run(argv=None):
                 for problem in linter.run(f, conf, filepath):
                     if args.format == 'parsable':
                         print(Format.parsable(problem, file))
-                    elif supports_color():
+                    elif args.format == 'colored' or \
+                            (args.format == 'auto' and supports_color()):
                         if first:
                             print('\033[4m%s\033[0m' % file)
                             first = False

yamllint/config.py

@@ -52,7 +52,7 @@ class YamlLintConfig(object):
         assert isinstance(base_config, YamlLintConfig)
 
         for rule in self.rules:
-            if (type(self.rules[rule]) == dict and
+            if (isinstance(self.rules[rule], dict) and
                     rule in base_config.rules and
                     base_config.rules[rule] is not False):
                 base_config.rules[rule].update(self.rules[rule])
@@ -70,7 +70,7 @@ class YamlLintConfig(object):
         except Exception as e:
             raise YamlLintConfigError('invalid config: %s' % e)
 
-        if type(conf) != dict:
+        if not isinstance(conf, dict):
             raise YamlLintConfigError('invalid config: not a dict')
 
         self.rules = conf.get('rules', {})
@@ -85,7 +85,7 @@ class YamlLintConfig(object):
                 raise YamlLintConfigError('invalid config: %s' % e)
 
         if 'ignore' in conf:
-            if type(conf['ignore']) != str:
+            if not isinstance(conf['ignore'], str):
                 raise YamlLintConfigError(
                     'invalid config: ignore should contain file patterns')
             self.ignore = pathspec.PathSpec.from_lines(
@@ -107,10 +107,10 @@ def validate_rule_conf(rule, conf):
     elif conf == 'enable':
         conf = {}
 
-    if type(conf) == dict:
+    if isinstance(conf, dict):
         if ('ignore' in conf and
-                type(conf['ignore']) != pathspec.pathspec.PathSpec):
+                not isinstance(conf['ignore'], pathspec.pathspec.PathSpec)):
-            if type(conf['ignore']) != str:
+            if not isinstance(conf['ignore'], str):
                 raise YamlLintConfigError(
                     'invalid config: ignore should contain file patterns')
             conf['ignore'] = pathspec.PathSpec.from_lines(
@@ -130,14 +130,14 @@ def validate_rule_conf(rule, conf):
                 raise YamlLintConfigError(
                     'invalid config: unknown option "%s" for rule "%s"' %
                     (optkey, rule.ID))
-            if type(options[optkey]) == tuple:
+            if isinstance(options[optkey], tuple):
                 if (conf[optkey] not in options[optkey] and
                         type(conf[optkey]) not in options[optkey]):
                     raise YamlLintConfigError(
                         'invalid config: option "%s" of "%s" should be in %s'
                         % (optkey, rule.ID, options[optkey]))
             else:
-                if type(conf[optkey]) != options[optkey]:
+                if not isinstance(conf[optkey], options[optkey]):
                     raise YamlLintConfigError(
                         'invalid config: option "%s" of "%s" should be %s'
                         % (optkey, rule.ID, options[optkey].__name__))

yamllint/linter.py

@@ -226,7 +226,7 @@ def run(input, conf, filepath=None):
     if conf.is_file_ignored(filepath):
         return ()
 
-    if type(input) in (type(b''), type(u'')):  # compat with Python 2 & 3
+    if isinstance(input, (type(b''), type(u''))):  # compat with Python 2 & 3
         return _run(input, conf, filepath)
     elif hasattr(input, 'read'):  # Python 2's file or Python 3's io.IOBase
         # We need to have everything in memory to parse correctly

yamllint/rules/document_end.py

@@ -86,14 +86,16 @@ CONF = {'present': bool}
 
 def check(conf, token, prev, next, nextnext, context):
     if conf['present']:
-        if (isinstance(token, yaml.StreamEndToken) and
+        is_stream_end = isinstance(token, yaml.StreamEndToken)
-                not (isinstance(prev, yaml.DocumentEndToken) or
+        is_start = isinstance(token, yaml.DocumentStartToken)
-                     isinstance(prev, yaml.StreamStartToken))):
+        prev_is_end_or_stream_start = isinstance(
+            prev, (yaml.DocumentEndToken, yaml.StreamStartToken)
+        )
+
+        if is_stream_end and not prev_is_end_or_stream_start:
             yield LintProblem(token.start_mark.line, 1,
                               'missing document end "..."')
-        elif (isinstance(token, yaml.DocumentStartToken) and
+        elif is_start and not prev_is_end_or_stream_start:
-                not (isinstance(prev, yaml.DocumentEndToken) or
-                     isinstance(prev, yaml.StreamStartToken))):
             yield LintProblem(token.start_mark.line + 1, 1,
                               'missing document end "..."')
 

yamllint/rules/indentation.py

@@ -224,7 +224,7 @@ def check_scalar_indentation(conf, token, context):
 
     def compute_expected_indent(found_indent):
         def detect_indent(base_indent):
-            if type(context['spaces']) is not int:
+            if not isinstance(context['spaces'], int):
                 context['spaces'] = found_indent - base_indent
             return base_indent + context['spaces']
 
@@ -312,7 +312,7 @@ def _check(conf, token, prev, next, nextnext, context):
                      token.start_mark.line + 1 > context['cur_line'])
 
     def detect_indent(base_indent, next):
-        if type(context['spaces']) is not int:
+        if not isinstance(context['spaces'], int):
             context['spaces'] = next.start_mark.column - base_indent
         return base_indent + context['spaces']
 

yamllint/rules/quoted_strings.py

@@ -16,8 +16,8 @@
 
 """
 Use this rule to forbid any string values that are not quoted.
-You can also enforce the type of the quote used - single or double - using the
+You can also enforce the type of the quote used using the ``quote-type`` option
-``quote-type`` option.
+(``single``, ``double`` or ``any``).
 
 **Note**: Multi-line strings (with ``|`` or ``>``) will not be checked.
 
@@ -51,24 +51,27 @@ CONF = {'quote-type': ('any', 'single', 'double')}
 def check(conf, token, prev, next, nextnext, context):
     quote_type = conf['quote-type']
 
-    if prev and isinstance(prev, yaml.tokens.TagToken):
+    if (isinstance(token, yaml.tokens.ScalarToken) and
-        if prev.value[1] != "str":
+            isinstance(prev, (yaml.ValueToken, yaml.TagToken))):
-            # we ignore generic strings, e.g. somestring: !!str testtest
+        # Ignore explicit types, e.g. !!str testtest or !!int 42
+        if (prev and isinstance(prev, yaml.tokens.TagToken) and
+                prev.value[0] == '!!'):
             return
 
-    if isinstance(token, yaml.tokens.ScalarToken):
+        # Ignore numbers, booleans, etc.
-        if isinstance(prev, yaml.tokens.ValueToken) or \
+        resolver = yaml.resolver.Resolver()
-           isinstance(prev, yaml.tokens.TagToken):
+        if resolver.resolve(yaml.nodes.ScalarNode, token.value,
-            if ((not token.plain) and
+                            (True, False)) != 'tag:yaml.org,2002:str':
-                    ((token.style == "|") or (token.style == ">"))):
+            return
-                # we ignore multi-line strings
-                return
 
-            if ((quote_type == 'single' and token.style != "'") or
+        # Ignore multi-line strings
-                    (quote_type == 'double' and token.style != '"') or
+        if (not token.plain) and (token.style == "|" or token.style == ">"):
-                    (quote_type == 'any' and token.style is None)):
+            return
-                yield LintProblem(
+
-                    token.start_mark.line + 1,
+        if ((quote_type == 'single' and token.style != "'") or
-                    token.start_mark.column + 1,
+                (quote_type == 'double' and token.style != '"') or
-                    "string value is not quoted with %s quotes" % (quote_type)
+                (quote_type == 'any' and token.style is None)):
-                )
+            yield LintProblem(
+                token.start_mark.line + 1,
+                token.start_mark.column + 1,
+                "string value is not quoted with %s quotes" % (quote_type))