Compare commits

...

2 Commits

Author SHA1 Message Date
Adrien Vergé
a09ad89268 yamllint version 1.27.1 2022-07-08 18:06:54 +02:00
Adrien Vergé
8d543a4b9c key-duplicates: Fix failing test for missing space after colon
Commit c268a82 "key-duplicates: Don't crash on redundant closing
brackets or braces" fixed a problem but introduced another one: it
crashes on systems with (I guess) an old version of PyYAML. This is
probably linked to the "Allow colon in a plain scalar in a flow context"
issue on PyYAML [1].
For example, this problem happens on CentOS 8:

    FAIL: test_disabled (tests.rules.test_key_duplicates.KeyDuplicatesTestCase)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "…/tests/rules/test_key_duplicates.py", line 90, in test_disabled
        '{a:1, b:2}}\n', conf, problem=(2, 11, 'syntax'))
      File "…/tests/common.py", line 54, in check
        self.assertEqual(real_problems, expected_problems)
    AssertionError: Lists differ: …
    - [2:3: syntax error: found unexpected ':' (syntax)]
    + [2:11: <no description>]

I propose to simply fix the *space following a colon* problem, since
it's not related to what the original author @tamere-allo-peter tried to
fix.

[1]: https://github.com/yaml/pyyaml/pull/45
2022-07-08 18:05:21 +02:00
3 changed files with 8 additions and 3 deletions

View File

@@ -1,6 +1,11 @@
Changelog
=========
1.27.1 (2022-07-08)
-------------------
- Fix failing test on ``key-duplicates`` for old PyYAML versions
1.27.0 (2022-07-08)
-------------------

View File

@@ -87,7 +87,7 @@ class KeyDuplicatesTestCase(RuleTestCase):
' <<: *anchor_one\n'
' <<: *anchor_two\n', conf)
self.check('---\n'
'{a:1, b:2}}\n', conf, problem=(2, 11, 'syntax'))
'{a: 1, b: 2}}\n', conf, problem=(2, 13, 'syntax'))
self.check('---\n'
'[a, b, c]]\n', conf, problem=(2, 10, 'syntax'))
@@ -169,7 +169,7 @@ class KeyDuplicatesTestCase(RuleTestCase):
' <<: *anchor_one\n'
' <<: *anchor_two\n', conf)
self.check('---\n'
'{a:1, b:2}}\n', conf, problem=(2, 11, 'syntax'))
'{a: 1, b: 2}}\n', conf, problem=(2, 13, 'syntax'))
self.check('---\n'
'[a, b, c]]\n', conf, problem=(2, 10, 'syntax'))

View File

@@ -21,7 +21,7 @@ indentation, etc."""
APP_NAME = 'yamllint'
APP_VERSION = '1.27.0'
APP_VERSION = '1.27.1'
APP_DESCRIPTION = __doc__
__author__ = u'Adrien Vergé'