1
0
mirror of synced 2026-02-06 19:05:55 +00:00

Fix flux migrate -f not considering kind comments

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
This commit is contained in:
Matheus Pimenta
2025-10-04 14:24:37 +01:00
parent f4a811fbd3
commit 7c5fb2297c
4 changed files with 5 additions and 4 deletions

View File

@@ -623,7 +623,8 @@ func (f *FileSystemMigrator) detectFileUpgrades(file string) ([]APIUpgrade, erro
if idx == -1 {
continue
}
kind := strings.TrimSpace(kindLine[idx+len(kindPrefix):])
kindValuePrefix := strings.TrimSpace(kindLine[idx+len(kindPrefix):])
kind := strings.Split(kindValuePrefix, " ")[0]
// Build GroupKind.
gk := schema.GroupKind{

View File

@@ -153,7 +153,7 @@ func TestFileSystemMigrator(t *testing.T) {
for _, wf := range tt.writtenFiles {
b, err := os.ReadFile(wf.goldenFile)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(fileSystem.writtenFiles[wf.file]).To(Equal(b),
g.Expect(string(fileSystem.writtenFiles[wf.file])).To(Equal(string(b)),
"file %s does not match golden file %s", wf.file, wf.goldenFile)
}
})

View File

@@ -12,7 +12,7 @@ spec:
wait: true
dependsOn:
- apiVersion: image.toolkit.fluxcd.io/v1 # update this from v1beta1
kind: ImageRepository
kind: ImageRepository # there can be comments here too
---

View File

@@ -12,7 +12,7 @@ spec:
wait: true
dependsOn:
- apiVersion: image.toolkit.fluxcd.io/v1beta1 # update this from v1beta1
kind: ImageRepository
kind: ImageRepository # there can be comments here too
---