Mirrors/flux2
1
0
Fork 0
mirror of synced 2026-02-08 03:35:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't swallow errors when uninstalling FluxCD

Browse Source 
Signed-off-by: Knut Götz <knutgoetz@gmail.com>
This commit is contained in:
Knut Götz
2023-11-10 15:44:33 +01:00
parent 3c8072d0e6
commit e6a7571a94
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cmd/flux/uninstall.go
View File

@@ -90,16 +90,24 @@ func uninstallCmdRun(cmd *cobra.Command, args []string) error {
} }
logger.Actionf("deleting components in %s namespace", *kubeconfigArgs.Namespace) logger.Actionf("deleting components in %s namespace", *kubeconfigArgs.Namespace)
uninstall.Components(ctx, logger, kubeClient, *kubeconfigArgs.Namespace, uninstallArgs.dryRun) if err := uninstall.Components(ctx, logger, kubeClient, *kubeconfigArgs.Namespace, uninstallArgs.dryRun); err != nil {
return err
}
logger.Actionf("deleting toolkit.fluxcd.io finalizers in all namespaces") logger.Actionf("deleting toolkit.fluxcd.io finalizers in all namespaces")
uninstall.Finalizers(ctx, logger, kubeClient, uninstallArgs.dryRun) if err := uninstall.Finalizers(ctx, logger, kubeClient, uninstallArgs.dryRun); err != nil {
return err
}
logger.Actionf("deleting toolkit.fluxcd.io custom resource definitions") logger.Actionf("deleting toolkit.fluxcd.io custom resource definitions")
uninstall.CustomResourceDefinitions(ctx, logger, kubeClient, uninstallArgs.dryRun) if err := uninstall.CustomResourceDefinitions(ctx, logger, kubeClient, uninstallArgs.dryRun); err != nil {
return err
}
if !uninstallArgs.keepNamespace { if !uninstallArgs.keepNamespace {
uninstall.Namespace(ctx, logger, kubeClient, *kubeconfigArgs.Namespace, uninstallArgs.dryRun) if err := uninstall.Namespace(ctx, logger, kubeClient, *kubeconfigArgs.Namespace, uninstallArgs.dryRun); err != nil {
return err
}
} }
logger.Successf("uninstall finished") logger.Successf("uninstall finished")