Mirrors/flux2
1
0
Fork 0
mirror of synced 2026-02-06 19:05:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2046 from vespian/prozlach/support_http_proxy_envs

Browse Source 
Use full domain name for notification-controller
This commit is contained in:
Stefan Prodan
2021-11-04 11:43:47 +02:00
committed by GitHub
parent c2c64a70c4 8ec5492d87
commit e7225db397
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/manifestgen/install/manifests.go
View File

@@ -65,7 +65,15 @@ func fetch(ctx context.Context, url, version, dir string) error {
func generate(base string, options Options) error {
if containsItemString(options.Components, options.NotificationController) {
options.EventsAddr = fmt.Sprintf("http://%s/", options.NotificationController)
// We need to use full domain name here, as some users may deploy flux
// in environments that use http proxy.
//
// In such environments they normally add `.cluster.local` and `.local`
// suffixes to `no_proxy` variable in order to prevent cluster-local
// traffic from going through http proxy. Without fully specified
// domain they need to mention `notifications-controller` explicity in
// `no_proxy` variable after debugging http proxy logs.
options.EventsAddr = fmt.Sprintf("http://%s.%s.svc.%s/", options.NotificationController, options.Namespace, options.ClusterDomain)
}
if err := execTemplate(options, namespaceTmpl, path.Join(base, "namespace.yaml")); err != nil {